QE-13273 Change the browser console log file suffix (#362)

The browser console log file is not recognized as text file by S3. Change the suffix to .txt instead.
dominodatalab · Sep 7, 2023 · 6012dfa · 6012dfa
1 parent 8cd0203
commit 6012dfa
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,9 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project closely adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 0.161.0
+- Change - add .txt as browser console log file suffix
+
 ## 0.160.0
 - Add - drag and drop file upload step
 

diff --git a/features/browser/console_logs.feature b/features/browser/console_logs.feature
@@ -10,13 +10,13 @@ Feature: Browser console logs
     #
     Given I skip this scenario if the current browser is not "chrome"
      When I run the command "cucu run data/features/scenario_with_console_logs.feature --results {CUCU_RESULTS_DIR}/console-logging" and save stdout to "STDOUT" and expect exit code "0"
-      And I should see the file at "{CUCU_RESULTS_DIR}/console-logging/Feature with console logs/Scenario with console logs/logs/browser_console.log" matches the following:
+      And I should see the file at "{CUCU_RESULTS_DIR}/console-logging/Feature with console logs/Scenario with console logs/logs/browser_console.log.txt" matches the following:
       """
       .* "INFO", "message": ".*/console_logging.html 4:12 \\"this is a regular log\\"", .*
       .* "SEVERE", "message": ".*/console_logging.html 5:12 \\"this is an error log\\"", .*
       .* "DEBUG", "message": ".*/console_logging.html 6:12 \\"this is a debug log\\"", .*
       .* "WARNING", "message": ".*/console_logging.html 7:12 \\"this is a warn log\\"", .*
       """
-      And I should see the file at "{CUCU_RESULTS_DIR}/console-logging/Feature with console logs/Scenario without console logs/logs/browser_console.log" is equal to the following:
+      And I should see the file at "{CUCU_RESULTS_DIR}/console-logging/Feature with console logs/Scenario without console logs/logs/browser_console.log.txt" is equal to the following:
       """
       """
diff --git a/features/cli/report_basics.feature b/features/cli/report_basics.feature
@@ -161,8 +161,8 @@ Feature: Report basics
       And I click the link "Feature with console logs"
       And I click the button "Scenario with console logs"
       And I click the button "Logs"
-     Then I should see the button "browser_console.log"
-     When I click the button "browser_console.log"
+     Then I should see the button "browser_console.log.txt"
+     When I click the button "browser_console.log.txt"
      Then I wait to see the text "this is a regular log"
       And I should see the text "this is an error log"
       And I should see the text "this is a debug log"

diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "cucu"
-version = "0.160.0"
+version = "0.161.0"
 license = "MIT"
 description = "Easy BDD web testing"
 authors = ["Domino Data Lab <[email protected]>"]

diff --git a/src/cucu/environment.py b/src/cucu/environment.py
@@ -171,7 +171,7 @@ def after_scenario(ctx, scenario):
         for browser in ctx.browsers:
             # save the browser logs to the current scenarios results directory
             browser_log_filepath = os.path.join(
-                ctx.scenario_logs_dir, "browser_console.log"
+                ctx.scenario_logs_dir, "browser_console.log.txt"
             )
 
             os.makedirs(os.path.dirname(browser_log_filepath), exist_ok=True)