Skip to content

fix clippy warnings #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
donhk merged 1 commit into from
May 17, 2025
Merged

fix clippy warnings #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 14 additions & 20 deletions rushstr-core/src/stores/vector_store.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,35 +102,29 @@ impl StoreTrait for VectorStore {
}

fn favorites(&self) -> anyhow::Result<usize> {
let mut favorites = 0;
for result in self.items.iter() {
if let Ok(result) = result.lock() {
if result.is_fav() {
favorites += 1;
}
}
}
let favorites = self
.items
.iter()
.filter_map(|item| item.lock().ok())
.filter(|item| item.is_fav())
.count();
Ok(favorites)
}

fn mark_favorite(&self, id: &Key) {
if let Some(h_item) = self.items_index.get(id) {
if let Ok(mut h_item) = h_item.lock() {
h_item.flip_fav();
if let Ok(bytes) = bincode::encode_to_vec(&*h_item, self.config) {
let _ = self.database.insert(h_item.id(), bytes);
}
if let Some(mut h_item) = self.items_index.get(id).and_then(|item| item.lock().ok()) {
h_item.flip_fav();
if let Ok(bytes) = bincode::encode_to_vec(&*h_item, self.config) {
let _ = self.database.insert(h_item.id(), bytes);
}
}
}

fn mark_hit(&self, id: &Key) {
if let Some(h_item) = self.items_index.get(id) {
if let Ok(mut h_item) = h_item.lock() {
h_item.inc_hits();
if let Ok(bytes) = bincode::encode_to_vec(&*h_item, self.config) {
let _ = self.database.insert(h_item.id(), bytes);
}
if let Some(mut h_item) = self.items_index.get(id).and_then(|item| item.lock().ok()) {
h_item.inc_hits();
if let Ok(bytes) = bincode::encode_to_vec(&*h_item, self.config) {
let _ = self.database.insert(h_item.id(), bytes);
}
}
}
Expand Down