Move detection of display-p3 capabilility to WebGL.js

donmccurdy · Aug 31, 2023 · 062373c · 062373c
1 parent bb4ab88
commit 062373c
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 18 deletions.
diff --git a/examples/jsm/capabilities/WebGL.js b/examples/jsm/capabilities/WebGL.js
@@ -30,6 +30,23 @@ class WebGL {
 
 	}
 
+	static isColorSpaceAvailable( colorSpace ) {
+
+		try {
+
+			const canvas = document.createElement( 'canvas' );
+			const ctx = window.WebGL2RenderingContext && canvas.getContext( 'webgl2' );
+			ctx.drawingBufferColorSpace = colorSpace;
+			return ctx.drawingBufferColorSpace === colorSpace; // deepscan-disable-line SAME_OPERAND_VALUE
+
+		} catch ( e ) {
+
+			return false;
+
+		}
+
+	}
+
 	static getWebGLErrorMessage() {
 
 		return this.getErrorMessage( 1 );

diff --git a/examples/webgl_test_wide_gamut.html b/examples/webgl_test_wide_gamut.html
@@ -72,12 +72,14 @@
 
 			import * as THREE from 'three';
 
+			import WebGL from 'three/addons/capabilities/WebGL.js';
+
 			let container, camera, renderer, loader;
 			let sceneL, sceneR, textureL, textureR;
 
 			let sliderPos = window.innerWidth / 2;
 
-			const isP3Context = THREE.ColorManagement.isDrawingBufferColorSpaceSupported( THREE.DisplayP3ColorSpace );
+			const isP3Context = WebGL.isColorSpaceAvailable( THREE.DisplayP3ColorSpace );
 
 			if ( isP3Context ) {
 

diff --git a/src/math/ColorManagement.js b/src/math/ColorManagement.js
@@ -139,23 +139,6 @@ export const ColorManagement = {
 
 	},
 
-	isDrawingBufferColorSpaceSupported: function ( colorSpace ) {
-
-		try {
-
-			const canvas = document.createElement( 'canvas' );
-			const ctx = window.WebGL2RenderingContext && canvas.getContext( 'webgl2' );
-			ctx.drawingBufferColorSpace = colorSpace;
-			return ctx.drawingBufferColorSpace === colorSpace; // deepscan-disable-line SAME_OPERAND_VALUE
-
-		} catch ( e ) {
-
-			return false;
-
-		}
-
-	}
-
 };