Skip to content

Conversation

@Dakraid
Copy link

@Dakraid Dakraid commented Mar 20, 2025

This is an implementation for HDR into Skyrim and Community Shaders.
Various issues still have to be resolved, and the tonemapper needs to be rewritten.

Known Issues:

  • Disabling HDR does not work properly (*1)
  • Mismatched output between non-TAA and TAA/FSR/DLSS (*2)
  • Output between FG on and off differs (*2)
  • Occasionally it requires opening the CS UI to work (*3)
  • Overall quality of the implementation
  • Further testing for various cases and combinations

Notes:

  1. Issues with disabling HDR may be related to the problem that it requires a restart but still immediately disables everything but not patched buffers or SwapChains.
    • Fixed by delaying application of the new state until after reload
  2. Mismatched output could be because of different input textures into the tonemapping shader
    • Fixed with the approach within commit a6fac0c
  3. For some reason opening the Display tab in the CS UI is sometimes (always?) required to get an image.
    • Fixed by updating the constant buffer variables after setup

Improvements:

  • Implement a check to see if a display even supports HDR output
  • Set HDR to default to off instead of on

Dakraid and others added 30 commits March 16, 2025 20:38
Various visual issues still persist as most shaders aren't HDR ready yet
Also settings ain't getting applied, go figure. Tonemapper is also a mess.
Also apply some more sensible settings as default
tssge added a commit to tssge/skyrim-community-shaders that referenced this pull request May 22, 2025
Meaningful changes picked from doodlum#1019

Get rid of tonemapping code and settings

I plan on letting DXVK or the compositor to handle proper PQ

Set DXGI buffer types based on HDR option
tssge added a commit to tssge/skyrim-community-shaders that referenced this pull request May 23, 2025
Meaningful changes picked from doodlum#1019

Get rid of tonemapping code and settings

I plan on letting DXVK or the compositor to handle proper PQ

Set DXGI buffer types based on HDR option

Move HDR state from ShaderCache to State

Fix menu

Fix warning

Add more debugging info

More fixes

Fix fix

style: 🎨 apply clang-format changes

Try with 10bit backbuffers

Fix

Some format changes

Attempt to apply PQ only once

style: 🎨 apply clang-format changes

Revert format change for upgrades

Try again

Not being ran

Fix

style: 🎨 apply clang-format changes

Fix upscaling

Some more fixes

Try without frame generation
May not compile yet, no fixes applied only merge conflict resolution
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 8, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link

github-actions bot commented Jul 8, 2025

Using provided base ref: dcdbaf3
Using base ref: dcdbaf3
Base commit date: 2025-08-17T20:52:19+01:00 (Sunday, August 17, 2025 08:52 PM)
No actionable suggestions for changed features.

@Dakraid Dakraid force-pushed the feature/hdr-output branch from 82e9981 to bab3d24 Compare August 15, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant