-
Notifications
You must be signed in to change notification settings - Fork 90
feat: Implement full HDR rendering into Community Shaders for Skyrim #1019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Various visual issues still persist as most shaders aren't HDR ready yet
Also settings ain't getting applied, go figure. Tonemapper is also a mess.
Also apply some more sensible settings as default
HDR is now directly done after Upscaling, color rotation is taken out
Musa is the MVP
Meaningful changes picked from doodlum#1019 Get rid of tonemapping code and settings I plan on letting DXVK or the compositor to handle proper PQ Set DXGI buffer types based on HDR option
Meaningful changes picked from doodlum#1019 Get rid of tonemapping code and settings I plan on letting DXVK or the compositor to handle proper PQ Set DXGI buffer types based on HDR option Move HDR state from ShaderCache to State Fix menu Fix warning Add more debugging info More fixes Fix fix style: 🎨 apply clang-format changes Try with 10bit backbuffers Fix Some format changes Attempt to apply PQ only once style: 🎨 apply clang-format changes Revert format change for upgrades Try again Not being ran Fix style: 🎨 apply clang-format changes Fix upscaling Some more fixes Try without frame generation
May not compile yet, no fixes applied only merge conflict resolution
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
82e9981 to
bab3d24
Compare
Automated formatting by clang-format, prettier, and other hooks. See https://pre-commit.ci for details.
This is an implementation for HDR into Skyrim and Community Shaders.
Various issues still have to be resolved, and the tonemapper needs to be rewritten.
Known Issues:
Notes:
Improvements: