Skip to content

chore: gate shader frame times #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from
Draft

chore: gate shader frame times #1429

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d98822e
Initial plan
Copilot Aug 23, 2025
df5ac9d
Gate per-shader frame time display behind developer mode
Copilot Aug 23, 2025
75c6410
Also gate A/B testing section behind developer mode
Copilot Aug 23, 2025
c8b690b
Allow draw calls to be shown to all users, gate only frame times
Copilot Aug 23, 2025
ffeb24b
style: 🎨 apply pre-commit.ci formatting
pre-commit-ci[bot] Aug 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/Features/PerformanceOverlay.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,10 @@ void PerformanceOverlay::DrawSettings()
ImGui::Indent();

ImGui::Checkbox("Show FPS Counter", &this->settings.ShowFPS);
ImGui::Checkbox("Show Draw Calls", &this->settings.ShowDrawCalls);
// Show Draw Calls setting is only available in developer mode
if (globals::state->IsDeveloperMode()) {
ImGui::Checkbox("Show Draw Calls", &this->settings.ShowDrawCalls);
}
ImGui::Checkbox("Show VRAM Usage", &this->settings.ShowVRAM);

bool isFrameGenerationActive = globals::upscaling && globals::upscaling->IsFrameGenerationActive();
Expand Down Expand Up @@ -297,7 +300,7 @@ void PerformanceOverlay::DrawOverlay()
float fpsWidth = ImGui::CalcTextSize(fpsText.c_str()).x;
minWidth = std::max(minWidth, fpsWidth + PerformanceOverlay::Settings::kLabelPadding); // Add padding for labels
}
if (this->settings.ShowDrawCalls) {
if (this->settings.ShowDrawCalls && globals::state->IsDeveloperMode()) {
// Draw calls table needs significant width for all columns
minWidth = std::max(minWidth, PerformanceOverlay::Settings::kDrawCallsTableWidth * this->settings.TextSize);
}
Expand Down Expand Up @@ -347,8 +350,8 @@ void PerformanceOverlay::DrawOverlay()
}
}

// Show Draw Calls if enabled
if (this->settings.ShowDrawCalls) {
// Show Draw Calls if enabled and in developer mode
if (this->settings.ShowDrawCalls && globals::state->IsDeveloperMode()) {
static bool drawCallsExpanded = true;
if (showCollapsibleSections) {
Util::DrawSectionHeader("Draw Calls & Shader Performance", false, true, &drawCallsExpanded);
Expand All @@ -373,7 +376,10 @@ void PerformanceOverlay::DrawOverlay()
ImGui::SetWindowFontScale(1.0f); // Reset font scale

// --- A/B Test Section ---
DrawABTestSection(allRows, showCollapsibleSections);
// A/B testing shows detailed per-shader performance data, so it should also be developer-only
if (globals::state->IsDeveloperMode()) {
DrawABTestSection(allRows, showCollapsibleSections);
}

ImGui::End();
ImGui::PopStyleVar(); // WindowBorderSize
Expand Down