Open
Conversation
|
@Agbasimere Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Owner
|
fix ci and conflicts. |
c7cd02b to
fd9af0f
Compare
…asimere/hintents into perf/snapshot-bench-overhead
Contributor
Author
|
@dotandev All checks passed, Kindly merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1021
Description
This PR addresses the performance tracking of the Soroban simulator's snapshot mechanism. It introduces a comprehensive benchmark to ensure that loading ledger snapshots (which populate the Host storage) does not degrade core simulation performance beyond acceptable limits.
Key Changes
criterion.criterionwithcsv_outputfor tracking results over time.cargo bench -- --testto prevent regressions during the build process.runnerpublic in lib.rs to allow the benchmark harness to initialize the simulation environment.Acceptance Criteria
File Changes
criterionand[[bench]]section.runnermodule for benchmarking.Testing
Ran baseline benchmark locally:
cd simulator cargo bench --bench snapshot_bench