Open
Conversation
|
@Miracle656 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Owner
|
fix ci and conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
================================================================================
TITLE:
feat(debug): Add SnapshotRegistry Interface - Issue #976
================================================================================
DESCRIPTION:
Overview
Implements a centralized
SnapshotRegistryinterface ininternal/debugfor storing and retrieving snapshots fetchedduring a session, decoupling UI components from storage implementation.
Changes
Core Implementation
SnapshotRegistry: New interface defined in
internal/debug/registry.goAdd(id string, snap *snapshot.Snapshot)— stores a snapshot by IDGet(id string) (*snapshot.Snapshot, bool)— retrieves a snapshot by IDListIDs() []string— returns all stored IDs in insertion orderClear()— removes all snapshots from the registrysnapshotRegistry: Private in-memory implementation of the interface
sync.RWMutexfor safe concurrent accessFactory Function:
NewSnapshotRegistry()returns a ready-to-use registryinternal/snapshotSecurity Properties
Related Issues
Closes #976
Type of Change
Checklist