Feature/issue 987 fast snapshot lookup#1035
Open
ayomideadeniran wants to merge 5 commits intodotandev:mainfrom
Open
Feature/issue 987 fast snapshot lookup#1035ayomideadeniran wants to merge 5 commits intodotandev:mainfrom
ayomideadeniran wants to merge 5 commits intodotandev:mainfrom
Conversation
- Add CircuitBreakerThreshold and CircuitBreakerTimeout fields to Config struct - Update TOML parser to read circuit_breaker_threshold and circuit_breaker_timeout - Add environment variable support: ERST_CIRCUIT_BREAKER_THRESHOLD and ERST_CIRCUIT_BREAKER_TIMEOUT - Add WithCircuitBreaker option to RPC client builder - Replace hardcoded circuit breaker values (5 failures, 60s) with configurable values - Provide sensible defaults matching current production behavior - Update erst.example.toml with circuit breaker documentation - Add comprehensive tests for circuit breaker configuration Fixes dotandev#849
- Create new package internal/telemetry/methods for method telemetry interfaces - Move MethodTelemetry and MethodTimer interfaces from internal/rpc to new package - Export NoopMethodTimer and DefaultMethodTelemetry for external use - Update all imports in internal/rpc to use the new package location - Maintain backward compatibility with existing telemetry consumers - Ensure seamless transition for all method telemetry implementations Fixes dotandev#850
Issue dotandev#987: - Add GetSnapshotAtInstruction() method with binary search - Implement snapshotIndex for fast instruction-based lookup - Optimize ReconstructStateAt() to use O(log N) search instead of O(N) - Achieve instantaneous navigation to specific steps Closes dotandev#987
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #987
#992
PULL REQUEST TEMPLATE
================================================================================
TITLE:
feat(audit): Add AWS KMS Direct Support for Signing -
================================================================================
DESCRIPTION:
Overview
Implements native AWS KMS direct support for audit trail signing, replacing pure PKCS#11 mapping with direct KMS API integration.
Changes
Core Implementation
KmsEd25519Signer: New plugin class implementing
AuditSignerinterfaceFactory Integration: Extended
createAuditSigner()to support 'kms' providerDependencies: Added
@aws-sdk/client-kmsv3.609.0Testing
Documentation
Security Properties
Configuration
Required environment variables:
ERST_KMS_KEY_ID: KMS key ARN or IDERST_KMS_PUBLIC_KEY_PEM: Ed25519 public key in PEM formatERST_KMS_REGION: AWS region (optional, defaults to us-east-1)IAM Permissions
Minimal policy required:
{ "Effect": "Allow", "Action": ["kms:Sign"], "Resource": "arn:aws:kms:*:ACCOUNT-ID:key/KEY-ID", "Condition": { "StringEquals": { "kms:SigningAlgorithm": "Ed25519" } } }Verification
Related Issues
Type of Change
Checklist
================================================================================