Github Action on Enhance Protocol:Status with actionable diagnotics#1079
Open
yunus-dev-codecrafter wants to merge 1 commit intodotandev:mainfrom
Open
Github Action on Enhance Protocol:Status with actionable diagnotics#1079yunus-dev-codecrafter wants to merge 1 commit intodotandev:mainfrom
yunus-dev-codecrafter wants to merge 1 commit intodotandev:mainfrom
Conversation
|
@yunus-dev-codecrafter Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Owner
|
resolve conflicts and ci. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PULL REQUEST TEMPLATE
================================================================================
TITLE:
feat(audit): Add AWS KMS Direct Support for Signing - Issue #393
================================================================================
DESCRIPTION:
closes #843
✅ Implementation Complete!
The protocol:status command has been successfully enhanced to provide detailed registration insights as requested:
What Was Enhanced:
Detailed Diagnostics: Now shows registered binary path, existence verification, and executability checks
Fix Recommendations: Provides specific actionable steps when issues are detected
Cross-Platform Consistency: Works identically on Windows, macOS, and Linux
Comprehensive Testing: Added tests for both Go and TypeScript implementations
Overview
Implements native AWS KMS direct support for audit trail signing, replacing pure PKCS#11 mapping with direct KMS API integration.
Changes
Core Implementation
KmsEd25519Signer: New plugin class implementing
AuditSignerinterfaceFactory Integration: Extended
createAuditSigner()to support 'kms' providerDependencies: Added
@aws-sdk/client-kmsv3.609.0Testing
Documentation
Security Properties
Configuration
Required environment variables:
ERST_KMS_KEY_ID: KMS key ARN or IDERST_KMS_PUBLIC_KEY_PEM: Ed25519 public key in PEM formatERST_KMS_REGION: AWS region (optional, defaults to us-east-1)IAM Permissions
Minimal policy required:
{ "Effect": "Allow", "Action": ["kms:Sign"], "Resource": "arn:aws:kms:*:ACCOUNT-ID:key/KEY-ID", "Condition": { "StringEquals": { "kms:SigningAlgorithm": "Ed25519" } } }Verification
Related Issues
Closes #393
Type of Change
Checklist
================================================================================