feat(ui): Colorize Ledger Diffs (Green/Red) with Legend - Issue #1010#1092
Open
ezedike-evan wants to merge 4 commits intodotandev:mainfrom
Open
feat(ui): Colorize Ledger Diffs (Green/Red) with Legend - Issue #1010#1092ezedike-evan wants to merge 4 commits intodotandev:mainfrom
ezedike-evan wants to merge 4 commits intodotandev:mainfrom
Conversation
- Add internal/ui/keys.go — Key type, KeyReader parsing raw stdin bytes and ANSI CSI escape sequences; TermSize() with $COLUMNS/$LINES fallback - Add internal/ui/layout.go — SplitLayout with ToggleFocus (Tab), left/right pane widths from SplitRatio, SIGWINCH listener via ListenResize(), side-by- side Render() zipping pre-built pane lines with │ divider; focused pane marked in border header - Add internal/ui/trace_view.go — TraceView wiring TreeRenderer to a state key-value table; HandleKey dispatches to focused pane; refreshState rebuilds table from selected node on every tree navigation event
- Add internal/ui/widgets/state_panel.go — DiffKind (added/removed/changed/same), ComputeDiff() diffs ExecutionState.HostState maps; StatePanel renders a 3-column table (indicator│Key│Old Value│New Value) with colour coding, proportional column widths, scrolling, and a Summary() status line - Add internal/ui/styles.go — centralised ANSI colour constants, Colorize(), NoColor global, DefaultBorder; widgets package exports its own copy to keep the dependency graph acyclic - Update internal/ui/layout.go — add PaneDiff pane constant, ShowDiff field, ToggleDiff(), MiddleWidth()/RightWidth() for three-pane column arithmetic, extend Render() signature to accept leftLines/middleLines/rightLines - Update internal/ui/trace_view.go — add diffPanel field and etrace param to NewTraceView; refreshDiff() wires ExecutionTrace steps to StatePanel.SetStates; HandleKey routes KeyDiff to ToggleDiff and PaneDiff nav to panel scroll - Update internal/ui/keys.go — add KeyDiff constant, map 'd'/'D' to it
…ng and a persistent footer legend
|
@ezedike-evan Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Owner
|
fix ci. |
Contributor
Author
than you chief |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(ui): Colorize Ledger Diffs (Green/Red) with Legend - Issue #1010
DESCRIPTION:
Overview
Extends the State Diff panel with full-row ANSI colour coding that is legible
on both light and dark terminal themes, and adds a persistent legend line at
the bottom of the panel.
Changes
Core Implementation
styles.go (
internal/ui/styles.go): New centralised styling module\033[1;32metc.) — the same codestcell uses internally, compatible with any tcell-capable terminal
DiffLegend()returns a colour-coded one-line legend stringNoColorglobal for piped/non-TTY outputstyleMapmakes adding new styles a one-line changeStatePanel (
internal/ui/widgets/state_panel.go): Full-row colouringDiffKind.valueStyles()— returns(oldStyle, newStyle)per kind:DiffAdded: old empty, newbold-greenDiffRemoved: oldbold-red, new emptyDiffChanged: olddim-red(secondary/was), newbold-green(primary/now)DiffSame: bothdim(recedes visually, not a change)bold-green,bold-red,bold-yellow) ensure legibilityon light-background terminals where plain colours wash out
dim-redfor "before" values in changed rows provides clear visualhierarchy without losing the information
Lines()updated:oldValandnewValcolourised viavalueStyles();selected row uses
bold-cyanfor high-contrast highlightoverflow, scroll position is prepended:
─ 1–20 of 47 Legend: [+]…dataRowsreduced by 1 (maxRows - 3) to permanently reserve the legendColorize()re-export extended withbold-*anddim-*variantsto match
styles.gowithout introducing a circular importColour Scheme