Skip to content

feat(presets/client): support enumValues option#10120

Merged
eddeee888 merged 2 commits intodotansimha:masterfrom
yangirov:master
Jun 5, 2025
Merged

feat(presets/client): support enumValues option#10120
eddeee888 merged 2 commits intodotansimha:masterfrom
yangirov:master

Conversation

@yangirov
Copy link
Copy Markdown
Contributor

@yangirov yangirov commented Aug 22, 2024

Description

Add support for enumValues in @graphql-codegen/client-preset.

Related #8562 (comment), #10349

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

N/A

How Has This Been Tested?

  • Added a test case for enumValues with enum replacement. Ran yarn test.

Test Environment:

  • OS: macOS Sonoma 14.6.1
  • @graphql-codegen/client-preset: 4.3.3
  • NodeJS: 20.14.0

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

The @graphql-codegen/client-preset package now supports the enumValues option.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Aug 22, 2024

🦋 Changeset detected

Latest commit: b96320c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/client-preset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yangirov
Copy link
Copy Markdown
Contributor Author

@dotansimha @saihaj Could you please review and run tests on this pull request?

Thanks!

@nathan-knight
Copy link
Copy Markdown

@dotansimha any chance someone can take a look at this? It's been 9 months and I've been maintaining a patch to do this in my project for a very long time.

@yangirov yangirov reopened this May 16, 2025
@yangirov
Copy link
Copy Markdown
Contributor Author

@dotansimha @eddeee888 this PR adds enumValues support to client-preset — small but important fix.

Tests pass, everything works. It’s been open for 9 months — would be great to get it merged 🙏

Thanks!

@yangirov
Copy link
Copy Markdown
Contributor Author

yangirov commented Jun 2, 2025

@eddeee888 @dotansimha ping

@dodomorandi
Copy link
Copy Markdown
Contributor

@yangirov I think you tagged me by mistake, I am not the maintainer of the project 😅

Copy link
Copy Markdown
Collaborator

@eddeee888 eddeee888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for bringing it to my attention!

@eddeee888 eddeee888 merged commit 98392fc into dotansimha:master Jun 5, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants