Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphiql): show input value deprecations #3712

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

ardatan
Copy link
Collaborator

@ardatan ardatan commented Jan 27, 2025

Show deprecated input fields, arguments and all other input values in GraphiQL
Fixes graphql-hive/gateway#535

Copy link

changeset-bot bot commented Jan 27, 2025

🦋 Changeset detected

Latest commit: e3ff0a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
graphql-yoga Patch
@graphql-yoga/graphiql Patch
@graphql-yoga/render-graphiql Patch
@graphql-yoga/nestjs Patch
@graphql-yoga/plugin-apollo-inline-trace Patch
@graphql-yoga/apollo-managed-federation Patch
@graphql-yoga/plugin-apollo-usage-report Patch
@graphql-yoga/plugin-apq Patch
@graphql-yoga/plugin-csrf-prevention Patch
@graphql-yoga/plugin-defer-stream Patch
@graphql-yoga/plugin-disable-introspection Patch
@graphql-yoga/plugin-graphql-sse Patch
@graphql-yoga/plugin-jwt Patch
@graphql-yoga/plugin-persisted-operations Patch
@graphql-yoga/plugin-prometheus Patch
@graphql-yoga/plugin-response-cache Patch
@graphql-yoga/plugin-sofa Patch
apollo-federation-gateway-with-yoga Patch
apollo-subgraph-with-yoga Patch
graphql-lambda Patch
cloudflare-advanced Patch
cloudflare Patch
nextjs-app Patch
hello-world-benchmark Patch
@graphql-yoga/nestjs-federation Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 27, 2025

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

@ardatan ardatan force-pushed the show-input-value-deprecations branch from ec5922c to e3ff0a9 Compare January 27, 2025 10:24
@ardatan ardatan requested a review from dotansimha January 27, 2025 10:25
Copy link
Owner

@dotansimha dotansimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. i also think it's a good default as graphiql is a developer tool.

Copy link
Contributor

💻 Website Preview

The latest changes are available as preview in: https://2a814e1e.graphql-yoga.pages.dev

@ardatan ardatan merged commit 1c055f5 into main Jan 27, 2025
24 checks passed
Copy link
Contributor

github-actions bot commented Jan 27, 2025

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}
     ✓ no_errors{mode:uws}
     ✓ expected_result{mode:uws}

     checks.......................................: 100.00% ✓ 519176      ✗ 0     
     data_received................................: 2.1 GB  14 MB/s
     data_sent....................................: 104 MB  696 kB/s
     http_req_blocked.............................: avg=1.55µs   min=1µs      med=1.34µs   max=3.33ms   p(90)=2.03µs   p(95)=2.22µs  
     http_req_connecting..........................: avg=2ns      min=0s       med=0s       max=153.38µs p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=358.59µs min=212.83µs med=327.86µs max=18.66ms  p(90)=472.37µs p(95)=493.29µs
       { expected_response:true }.................: avg=358.59µs min=212.83µs med=327.86µs max=18.66ms  p(90)=472.37µs p(95)=493.29µs
     ✓ { mode:graphql-jit }.......................: avg=282.89µs min=212.83µs med=267.42µs max=18.66ms  p(90)=297.33µs p(95)=308.85µs
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=497.39µs min=414.17µs med=475.39µs max=6.9ms    p(90)=513.89µs p(95)=550.84µs
     ✓ { mode:graphql-response-cache }............: avg=345.42µs min=268.89µs med=328.56µs max=7.66ms   p(90)=358.61µs p(95)=369.23µs
     ✓ { mode:graphql }...........................: avg=364.19µs min=278.38µs med=338.13µs max=14.04ms  p(90)=385.84µs p(95)=428.28µs
     ✓ { mode:uws }...............................: avg=342.8µs  min=267.31µs med=325.75µs max=5.88ms   p(90)=358.34µs p(95)=378.21µs
     http_req_failed..............................: 0.00%   ✓ 0           ✗ 259588
     http_req_receiving...........................: avg=33.25µs  min=16.19µs  med=32.86µs  max=2.9ms    p(90)=39.65µs  p(95)=42.14µs 
     http_req_sending.............................: avg=8.78µs   min=6.02µs   med=7.74µs   max=371.3µs  p(90)=11.16µs  p(95)=12.26µs 
     http_req_tls_handshaking.....................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=316.54µs min=180.26µs med=286.95µs max=18.55ms  p(90)=429.67µs p(95)=448.86µs
     http_reqs....................................: 259588  1730.571595/s
     iteration_duration...........................: avg=572.83µs min=377.89µs med=538.01µs max=19.21ms  p(90)=689.62µs p(95)=714.51µs
     iterations...................................: 259588  1730.571595/s
     vus..........................................: 1       min=1         max=1   
     vus_max......................................: 2       min=2         max=2   

@ardatan ardatan deleted the show-input-value-deprecations branch January 27, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IntrospectionQuery does not include @deprecated input fields
2 participants