Switch from ES6 to ES5 to ensure compatability. #4
+25
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Runes** is not compiled with Babel, which leads to some difficulty when depending on it. It is currently [not possible](https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#npm-run-build-fails-to-minify) to use `runes` in projects using `create-react-app`. The only ES6 features being used by **runes** are `const` and `let`. I therefore suggest that we switch to ES5, or add a compile step.
|
I second this, have to fork the repo into my local and add babel to compile down to es5. |
|
This is crucial for modern build processes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runes is not compiled with Babel, which leads to some difficulty when depending on it.
It is currently not possible to use
runesin projects usingcreate-react-app.The only ES6 features being used by runes are
constandlet. I therefore suggest that we switch to ES5, or add a compile step.