Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Benchmark Accuracy #2336

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Improve Benchmark Accuracy #2336

wants to merge 9 commits into from

Conversation

timcassell
Copy link
Collaborator

@timcassell timcassell commented Jun 21, 2023 •
edited
Loading

Fixes #1133
Fixes #2305
Fixes #1802
Fixes #2530

  • Drastically simplified benchmark type code gen.
  • Overhead return type is always void for a fair baseline for all benchmark return types.
  • Benchmark method is called directly instead of wrapped in a delegate.
  • Return value is popped off the stack instead of passed to Consumer or a NoInlining method.
  • Added an assembly weaver that automatically applies MethodImplOptions.NoInlining to benchmark methods.
  • Added additional tests.

@timcassell timcassell mentioned this pull request Jun 21, 2023
Closed
@timcassell timcassell marked this pull request as draft July 24, 2023 15:45
@timcassell timcassell marked this pull request as ready for review August 1, 2023 07:26
This was referenced Aug 9, 2023
Closed
Open
@timcassell timcassell added this to the v0.14.0 milestone Jan 14, 2024
@timcassell timcassell mentioned this pull request Jan 22, 2024
Closed
@timcassell timcassell modified the milestones: v0.15.x, v0.14.0 Mar 6, 2024
@timcassell

This comment was marked as outdated.

Sign in to view
@timcassell timcassell force-pushed the fair-types branch 2 times, most recently from 48266cd to 4abbb1f Compare March 11, 2024 14:08
@timcassell timcassell modified the milestones: v0.14.0, v0.15.x Aug 6, 2024
@timcassell timcassell mentioned this pull request Jan 11, 2025
Closed
@timcassell timcassell marked this pull request as draft January 13, 2025 00:58
@timcassell timcassell mentioned this pull request Feb 13, 2025
Open
@timcassell timcassell changed the title Fair Return Types Improve Benchmark Accuracy Feb 13, 2025
@timcassell timcassell marked this pull request as ready for review February 13, 2025 21:53
@timcassell
Copy link
Collaborator Author

timcassell commented Feb 13, 2025 •
edited
Loading

Unfortunately, I no longer have an Intel CPU to test this, but I think the new results from this PR should address the issues you had in #2334 @AndreyAkinshin (results look good on my AMD 9800X3D CPU in .Net 8).

@timcassell
Added assembly weaver.
f1a89ed 
Reverted loop methods back to `AggressiveOptimization`.
Added `NoInlining` to `__Overhead` to match weaved benchmark method.
Updated ExpectedBenchmarkResultsTests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreyAkinshin AndreyAkinshin Awaiting requested review from AndreyAkinshin

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Area:CodeGen
Projects
None yet
Milestone
v0.15.x
2 participants
@timcassell @AndreyAkinshin