Merge pull request #1107 from MattKotsenas/bugfix/1067-rebuild-package

Ensure GetBuildVersion runs before Clean
dotnet · Oct 17, 2024 · 62dbaa6 · 62dbaa6
2 parents 41ee52c + d2e7eee
commit 62dbaa6
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/src/Nerdbank.GitVersioning.Tasks/build/Nerdbank.GitVersioning.targets b/src/Nerdbank.GitVersioning.Tasks/build/Nerdbank.GitVersioning.targets
@@ -8,6 +8,11 @@
       $(VersionDependsOn)
     </VersionDependsOn>
 
+    <CleanDependsOn>
+      GetBuildVersion;
+      $(CleanDependsOn)
+    </CleanDependsOn>
+
     <GenerateNuspecDependsOn>
       GetBuildVersion;
       $(GenerateNuspecDependsOn)

diff --git a/test/Nerdbank.GitVersioning.Tests/BuildIntegrationTests.cs b/test/Nerdbank.GitVersioning.Tests/BuildIntegrationTests.cs
@@ -131,6 +131,14 @@ public async Task GetBuildVersion_Without_Git()
         Assert.Equal("3.4.0", buildResult.AssemblyInformationalVersion);
     }
 
+    [Fact]
+    public async Task GetBuildVersion_Hooks_Clean()
+    {
+        this.WriteVersionFile("1.2");
+        BuildResults buildResult = await this.BuildAsync("Clean");
+        Assert.Equal("1.2", buildResult.BuildVersion);
+    }
+
     [Fact]
     public async Task GetBuildVersion_Without_Git_HighPrecisionAssemblyVersion()
     {