Enhanced Input Events #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perksey
reviewed
Mar 5, 2021
|
Are there plans to update this proposal according to feedback? |
|
|
Perksey
requested changes
Jul 3, 2021
There was a problem hiding this comment.
Just one last comment remaining for the preliminary review (before we take this to the working group again) about adding constructors to the API, but generally I like this pattern of "event being an action, event parameters being a struct" i.e. "user has pressed a button down, here's a struct containing which button". I don't think one event should reflect multiple logical actions so I've discarded my comments suggesting this.
Feel free to change up the proposal as well if after a nearly half a year you've got some new ideas. I've retargeted the PR to use the 3.0 proposals branch.
Perksey
requested changes
Jul 17, 2021
Co-authored-by: Dylan Perks <[email protected]>
Perksey
approved these changes
Jul 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Adds missing input functionality, as discussed in Discord and in issue #399