Test a project with a Space in the project Name #10006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
force-pushed
the
dev/dellis1972/WI1852953
branch
from
115a545 to
cb6249a
Compare
dellis1972
commented
Apr 4, 2025
dellis1972
force-pushed
the
dev/dellis1972/WI1852953
branch
from
cb6249a to
89ec6fd
Compare
grendello
reviewed
Apr 8, 2025
| @@ -181,7 +181,7 @@ protected override string GenerateCommandLineCommands () | |||
| if (!string.IsNullOrEmpty (EnumMetadataDirectory)) | |||
| WriteLine (sw, $"--enummetadata=\"{EnumMetadataDirectory}\""); | |||
| if (!string.IsNullOrEmpty (AssemblyName)) | |||
| WriteLine (sw, $"--assembly={AssemblyName}"); | |||
| WriteLine (sw, $"--assembly=\"{AssemblyName}\""); | |||
There was a problem hiding this comment.
This could use MonoAndroidHelper.QuoteFileNameArgument, so that we have quoting code in a single place
There was a problem hiding this comment.
Its a good idea. However, this file is full off "\"" entries, so I feel we would need to change all of them.
Also QuoteFileNameArgument creates a new CommandLineBuilder every time its called, it feels like just hard coding the quotes at this point would be more efficient? 🤷
There was a problem hiding this comment.
It's definitely more efficient, no doubt, but the command line builder might be doing more than just quoting (I assume) :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1852953
There was a problem with the generator arguments not allowing for assembly names with spaces in them.
So lets fix that by adding quotes to make sure the assembly name is parsed correctly. Also add a unit test to make sure we don't regress in the future.