Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ReadyToRun deployments are enabled when:
<PublishReadyToRun>true</PublishReadyToRun>
is added to the project filedotnet publish
Once enabled, the SDK injects necessary build tasks to perform AOT compilation of assemblies after their trimming and creation of R2R images during app publish.
Problem
Currently, Android app build runs two assembly postprocessing build tasks (after R2R image generation):
RewriteMarshalMethods
andRemoveRegisterAttribute
that are modifying assemblies withMono.Cecil
. However, altering R2R assemblies is not supported with Mono.Cecil and build fails via:Changes
To enable R2R builds, this PR:
RewriteMarshalMethods
andRemoveRegisterAttribute
build tasks in ReadyToRun deploymentsFuture work
Investigate running R2R image generation build task after
RewriteMarshalMethods
andRemoveRegisterAttribute
so that R2R builds could also benefit from the performance improvements these build tasks bring.