Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a tool and msbuild task to find differences in nuget packages #14460

Closed
wants to merge 3 commits into from

Conversation

jtschuster
Copy link
Member

Creates a command line tool and an msbuild tooltask to find differences in nuget packages. It does a git-style diffing to show line by line differences in the list of files in the package and in the nuspec file. There isn't yet a way to handle expected differences, so the msbuild task always succeeds, but will log any differences it finds.

I'm planning to do more in depth checks on each assembly in the packages and check for each member on each type and take a list of assemblies with expected differences to skip these checks.

Part of dotnet/source-build#4051

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why arcade? I would have assumed this tool to be added to dotnet/dotnet (-> dotnet/installer) under tools. That's the place where we have our other msbuild tasks that we then use to analyze the product, i.e. pre-built detection, poison detection, etc.

@jtschuster
Copy link
Member Author

jtschuster commented Feb 8, 2024

Why arcade?

No reason in particular, this just came to mind first. I'll move it.

@jtschuster jtschuster closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants