Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RequiresUnreferencedCode in IJSInProcessObjectReference #58713

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yueyinqiu
Copy link

@yueyinqiu yueyinqiu commented Oct 30, 2024

Just to remove [RequiresUnreferencedCode] in IJSInProcessObjectReference

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Fixes #58712

(It is a really minor change so I just submit the pr without discussion.)

@yueyinqiu yueyinqiu requested a review from a team as a code owner October 30, 2024 07:19
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-blazor Includes: Blazor, Razor Components label Oct 30, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 30, 2024
Copy link
Contributor

Thanks for your PR, @yueyinqiu. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@martincostello
Copy link
Member

I believe the attribute is there for the object array for serializing the function parameters.

@yueyinqiu
Copy link
Author

yueyinqiu commented Oct 30, 2024

Hmmm... that might be the point.. but why IJSObjectReference does not have that attribute?

@yueyinqiu
Copy link
Author

Actually I have no idea how to resolve this warning cleanly (just suppress it?):

image

@javiercn
Copy link
Member

I mentioned on the original issue that I don't believe removing the attribute is the solution

#58712 (comment)

@yueyinqiu yueyinqiu marked this pull request as draft November 6, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blazor IJSInProcessObjectReference.Invoke is attributed with RequiresUnreferencedCode
4 participants