feat: analyzer and codeFix for kestrel setup ListenOptions.Listen(IPAddress.Any) usage
#58872
+334
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeagleGross
added
the
analyzer
dotnet-issue-labeler
bot
added
the
area-infrastructure
src/Framework/AspNetCoreAnalyzers/src/Analyzers/DiagnosticDescriptors.cs
Outdated
Show resolved
Hide resolved
|
@dotnet-policy-service agree company="Microsoft" |
halter73
reviewed
Nov 11, 2024
src/Framework/AspNetCoreAnalyzers/src/Analyzers/DiagnosticDescriptors.cs
Outdated
Show resolved
Hide resolved
src/Framework/AspNetCoreAnalyzers/src/Analyzers/Kestrel/ListenOnIPv6AnyAnalyzer.cs
Show resolved
Hide resolved
src/Framework/AspNetCoreAnalyzers/src/CodeFixes/Kestrel/ListenOnIPv6AnyFixer.cs
Outdated
Show resolved
Hide resolved
DeagleGross
requested review from
captainsafia and
mkArtakMSFT
as code owners
3 tasks
halter73
approved these changes
Nov 12, 2024
halter73
reviewed
Nov 12, 2024
halter73
reviewed
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a machine that supports IPv6, listening to
Any, rather thanIPv6Anywill either not work or be slower than necessary. For HTTP/1.x and 2/0, a name likelocalhostwill resolve to[::1], which won't be accepted by the server, forcing a retry with127.0.0.1(i.e. failed attempt before each connection).Implemented in a way, as specified by @amcasey:
PR adds the analyzer, which catches
options.Listen(IPAddress.Any, ...)usage, and a code fix, which explicitly changes the argument toIPAddress.IPv6Any.Docs PR
Fixes #58172