-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put package assets in TFM-specific folder #58995
base: main
Are you sure you want to change the base?
Conversation
Test build to get packages: https://dev.azure.com/dnceng/internal/_build/results?buildId=2582989&view=results |
Thanks for reporting this @loganmj and thanks @BrennanConroy and @wtgodbe for the quick investigation/fix! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does ApiDescription.Server need a similar treatment?
It does, nice catch. Plus I need to fix up |
Actually, not sure if we can fix APIDescription.Server since it targets netcoreapp2.1, |
We make sure to use TFMs with all assets, including I don't think an of our packages use |
Fixes #58990
Related: NuGet/Home#6932
When a package has a
build
orbuildmultitargeting
folder without a TFM subfolder, NuGet considers it to be compatible with any TFM. This is causing builds that should be failing with restore errors, to instead later hit a less helpful runtime error.