-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update project templates use primary constructors and collection expressions #59712
Conversation
@danroth27 ping |
@Varorbc apologies for delay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution!
It looks great overall! The move to primary constructors here has revealed places where we were initializing but not using ILogger
s. I think it might be worthwhile to continue to inject ILogger's into the classes via the primary constructor but add code to use them in the class so that the functionality is properly demonstrated.
src/ProjectTemplates/Web.ProjectTemplates/content/GrpcService-CSharp/Services/GreeterService.cs
Outdated
Show resolved
Hide resolved
src/ProjectTemplates/Web.ProjectTemplates/content/WebApiAot-CSharp/Program.cs
Outdated
Show resolved
Hide resolved
@captainsafia ping |
@captainsafia ... I think we'll have two documentation example changes to mirror these updates. I'll take care of opening and working the doc issue. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Our existing template tests give us good coverage here and we'll be able to do some manual validation on this change once it flows through to main.
update project templates use primary constructors
Description
Fixes #52893