Skip to content

Conversation

@sebastienros
Copy link
Member

No description provided.

Copy link
Member

@LoopedBard3 LoopedBard3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍.

@LoopedBard3 LoopedBard3 requested a review from Copilot August 26, 2025 19:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds functionality to optionally keep child processes alive after the main benchmark job completes. The feature allows users to specify whether a tracked child process should be terminated or kept running when the benchmark finishes.

  • Adds a new KeepChildProcessAlive boolean property to the Job model with a default value of false
  • Updates the EventSource API to accept an optional keepAlive parameter when setting child process IDs
  • Modifies the job termination logic to skip killing child processes when the keep-alive flag is enabled

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/Microsoft.Crank.Models/Job.cs Adds the KeepChildProcessAlive property to the Job class
src/Microsoft.Crank.Jobs.Bombardier/Microsoft.Crank.Jobs.Bombardier.csproj Updates C# language version to Latest
src/Microsoft.Crank.EventSources/Microsoft.Crank.EventSources.csproj Updates C# language version to Latest
src/Microsoft.Crank.EventSources/BenchmarksEventSource.cs Modifies SetChildProcessId method to accept optional keepAlive parameter
src/Microsoft.Crank.Controller/README.md Documents the new --[JOB].keepChildProcessAlive command-line option
src/Microsoft.Crank.Controller/Documentation.cs Adds documentation for the new keep-alive option
src/Microsoft.Crank.Agent/Startup.cs Implements parsing logic and termination behavior for the keep-alive feature

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants