Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stats feature to secret-manager #4970

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

garath
Copy link
Member

@garath garath commented Feb 11, 2025

@garath garath requested a review from Copilot February 11, 2025 23:48
@garath garath self-assigned this Feb 11, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (3)

src/SecretManager/Microsoft.DncEng.SecretManager/Commands/StatsCommand.cs:72

  • Error message should specify which files are missing.
throw new FailWithExitCodeException(86, "The following manifest files were not found: {Environment.NewLine} {string.Join(Environment.NewLine, missingManifestFiles)}");

src/SecretManager/Microsoft.DncEng.SecretManager/Commands/StatsCommand.cs:80

  • Error message should specify which directories are missing or empty.
throw new FailWithExitCodeException(86, "The following manifest directories were not found or contained no manifests: {Environment.NewLine} {string.Join(Environment.NewLine, missingOrEmptyManifestPaths)}");

src/SecretManager/Microsoft.DncEng.SecretManager/Commands/StatsCommand.cs:145

  • [nitpick] Use '_console.WriteLine' for consistency.
Console.WriteLine("No human required secrets found");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gather data on secret-manager entries that require manual intervention
1 participant