Freshness Edit: dotnet content #45326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
dotnet-fundamentals/svc
community-contribution
|
Hi @IEvangelist @BillWagner - Another edit pass ready for your review. I tried a different style for the Before/After code bocks to make it easier for the reader to compare the changes. There are also open GH issues for this topic. See top comment for details. Thank you. |
BillWagner
approved these changes
Mar 20, 2025
There was a problem hiding this comment.
Hi @GitHubber17
This looks great. I found a couple small nits to address. I'll commit the suggestions and merge it now.
|
@GitHubber17 OK, it turns out there are a lot of lint issues. Can you fix those? Then, I'll merge it. |
IEvangelist
reviewed
Mar 20, 2025
auto-merge was automatically disabled
March 20, 2025 17:26
Head branch was pushed to by a user without write access
|
@BillWagner @IEvangelist - Thank you for your feedback. I applied the updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains freshness updates for Unit testing best practices with .NET Core and .NET Standard
There are two open GitHub issues for this article. I addressed one in my updates, but the other needs input:
See ADO request 365082 for details.
Internal previews