Merged
Conversation
Fixes dotnet#51441 The feature for collection expression arguments adds these six diagnostic codes.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR wires up documentation for the new with(...) collection expression argument diagnostics and removes them from the generic “sorry, we don’t have specifics” catch-all page. It also updates TOC metadata so the new diagnostics are discoverable from the language reference.
Changes:
- Removed CS9354–CS9359 from the generic
sorry-we-don-t-have-specifics-on-this-csharp-error.mdlist now that they have dedicated coverage. - Added CS9354–CS9359 to
array-declaration-errors.md, including F1/helpviewer keywords, the error list, and guidance on how to resolve the diagnostics, and updatedms.date. - Updated
language-reference/toc.ymldisplay names to surface the new diagnostics in navigation (though currently pointing them at the inline arrays entry instead of the array/collection declarations entry).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/csharp/misc/sorry-we-don-t-have-specifics-on-this-csharp-error.md | Updates ms.date, adds C# version grouping comments, and removes CS9354–CS9359 from the undocumented diagnostics list now that they are documented elsewhere. |
| docs/csharp/language-reference/toc.yml | Extends the inline arrays compiler-messages TOC entry’s displayName list to include CS9354–CS9359, but does not yet add them to the array declarations entry where the new content actually lives. |
| docs/csharp/language-reference/compiler-messages/array-declaration-errors.md | Adds CS9354–CS9359 to F1/helpviewer keywords, the “covered errors” list, and the guidance section for collection expression/initializer diagnostics, and updates ms.date and metadata accordingly. |
Member
Author
|
@adegeo This is ready for review. |
gewarren
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51441
The feature for collection expression arguments adds these six diagnostic codes.
Internal previews