Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up paramrefs (System namespace) #10184

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Conversation

gewarren
Copy link
Contributor

Contributes to #10183

(Hide whitespace changes.)

@gewarren gewarren requested review from a team as code owners July 31, 2024 02:59
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Jul 31, 2024

This comment was marked as outdated.

Copy link

Learn Build status updates of commit 4a67849:

✅ Validation status: passed

File Status Preview URL Details
xml/index.xml ✅Succeeded
xml/System/Activator.xml ✅Succeeded View
xml/System/AppDomain.xml ✅Succeeded View
xml/System/ArgumentException.xml ✅Succeeded View
xml/System/ArgumentOutOfRangeException.xml ✅Succeeded View
xml/System/Array.xml ✅Succeeded View
xml/System/ArraySegment`1.xml ✅Succeeded View
xml/System/Attribute.xml ✅Succeeded View
xml/System/Convert.xml ✅Succeeded View
xml/System/DateTime.xml ✅Succeeded View
xml/System/DateTimeOffset.xml ✅Succeeded View
xml/System/Decimal.xml ✅Succeeded View
xml/System/Delegate.xml ✅Succeeded View
xml/System/Double.xml ✅Succeeded View
xml/System/Enum.xml ✅Succeeded View
xml/System/Environment.xml ✅Succeeded View
xml/System/Guid.xml ✅Succeeded View
xml/System/IComparable.xml ✅Succeeded View
xml/System/Int16.xml ✅Succeeded View
xml/System/Int32.xml ✅Succeeded View
xml/System/IntPtr.xml ✅Succeeded View
xml/System/Lazy`1.xml ✅Succeeded View
xml/System/Math.xml ✅Succeeded View
xml/System/MathF.xml ✅Succeeded View
xml/System/Memory`1.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admittedly skimmed this, but it looks good.

Let's :shipit: when ready.

@gewarren gewarren merged commit 0d795ed into dotnet:main Jul 31, 2024
3 checks passed
@gewarren gewarren deleted the system-paramrefs branch July 31, 2024 16:53
@gewarren
Copy link
Contributor Author

Thanks @BillWagner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants