-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed documentation for MemoryLoadBytes #10303
base: main
Are you sure you want to change the base?
Conversation
Tagging subscribers to this area: @dotnet/area-system-runtime |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this. The wording wasn't exactly clear to me, so I left a suggested change.
Co-authored-by: Genevieve Warren <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, forgot to change the link in my previous review. We're required to leave off the learn.microsoft.com/locale part of URLs for them to resolve in air-gapped environments.
This comment was marked as outdated.
This comment was marked as outdated.
this still reads a bit confusing to me. for example, not sure how the reader would interpret what when a process is not running in a container or running in a container without a memory limit -
when a process is running in a container with a memory limit -
also CC-ing @janvorli for review on info about non windows side of things. |
Co-authored-by: Genevieve Warren <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@janvorli, any feedback here? Explicitly highlighted the source of the memory load calculation, which prior to this change was ambiguously stated. Based on the code of |
Learn Build status updates of commit 832b8f5: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Summary
Fixed documentation for the
MemoryLoadBytes
section as it was misleading before as it's not a percentage but a quantity with units in bytes.Fixes an issue in the runtime repo: dotnet/runtime#106712
CC: @Maoni0 @cshung @mangod9 @markples