Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated information from SubjectKeyIdentifierHashAlgorithm docs #10789

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vcsjones
Copy link
Member

@vcsjones vcsjones commented Dec 26, 2024

Summary

This removes some text from the Remarks section of the SKI that are outdated.

  1. SKIs are not just limited to "working with XML digital signing" so just remove it.
  2. A SKI can use hash algorithms other than SHA-1, and it might hash different parts of the certificate like the subjectPublicKey or the SubjectPublicKeyInfo. What exactly is used is documented in each member of the enum, so I don't think we need to say anything about it in remarks.

@vcsjones vcsjones requested a review from a team as a code owner December 26, 2024 21:33
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-System.Security Issues related to security practices for .NET developers. label Dec 26, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones

Copy link

Learn Build status updates of commit 0c34959:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Security.Cryptography.X509Certificates/X509SubjectKeyIdentifierHashAlgorithm.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Security Issues related to security practices for .NET developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants