Skip to content

Conversation

@ronnelsantiago
Copy link

Should it say sent?

Summary

Describe your changes here.

Fixes #Issue_Number (if available)

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-System.ServiceModel labels Jul 7, 2023
@learn-build-service-prod
Copy link

Learn Build status updates of commit 7946e97:

✅ Validation status: passed

File Status Preview URL Details
xml/System.ServiceModel.Channels/RemoteEndpointMessageProperty.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@mconnew
Copy link
Member

mconnew commented Jul 9, 2023

The grammar and phrasing used is confusing but I believe the original text is correct. The misunderstanding is because of how poorly the description was written. The word received is in context of "from" so it's saying a message was received and the ip address and port is for where the message came from.
The whole sentence could do with being reworded to be less confusing, but received is correct with the current text.

@mconnew
Copy link
Member

mconnew commented Jul 10, 2023

I had another look at the text and I understand why it's worded awkwardly. It's not always the ip address of the sender. If there's a relay in the middle such as an HTTP proxy, it will be the source IP address and port number of the connection from the HTTP proxy. The term sender implies the original source of the message so that would be misleading. It could maybe be reworded as saying it's usually the ip of the sender and then add if a relay or proxy is involved, then it will instead be the ip of the the relay or proxy that connected to the service. It's wordier but I think would be clearer.

Copy link
Member

@mconnew mconnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original text was correct, just a little confusing. Either leave as is or reword the entire paragraph to make it less confusing.

@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jul 10, 2023
@Daniel182020
Copy link

Should it say sent?
sent

Summary

the house of God.json

Describe your changes here.
Daniel182020
Fixes #Issue_Number (if a
God keep wallet.json
vailable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.ServiceModel community-contribution Indicates that the PR has been added by a community member needs-author-action An issue or pull request that requires more info or actions from the author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants