[release/8.0] Stop stripping new lines from migration script literals (#32788) #32851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
approved these changes
Jan 17, 2024
|
Note that the branch is currently closed |
@ErikEJ Since you've been asking, this means we're done for 8.0.2 now. Any new patches will wait for 8.0.3. |
|
@ajcvickers Thanks for the info! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #32788
Fixes #32730
Description
Replacement of a regex results in empty lines being stripped from literals in migrations when they were not stripped before.
Customer impact
Corrupted literals in migrations.
How found
Customer reported on 8.
Regression
Yes, from 7.
Testing
Tests added.
Risk
Low. Quirked.