Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Stop using case-insensitive comparisons for indexed properties (#32899) #32919

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

ajcvickers
Copy link
Contributor

Port of #32899
Fixes #32898

Description

EF8 contained a small enhancement to match SQL Server defaults and do case-insensitive comparisons by default. This change also included properties with indexes, which was a mistake.

Customer impact

Customers get incorrect change detection, resulting in possible corrupted data, on index properties.

How found

Customer reported on 8.

Regression

Yes, from 7.

Testing

Tests added.

Risk

Low. Quirked.

Fixes #32898

Note that we didn't change what we do in the update pipeline, which appears to already be using provider values.
@ajcvickers ajcvickers requested a review from a team January 25, 2024 11:33
@ajcvickers ajcvickers changed the title Stop using case-insensitive comparisons for indexed properties (#32899) [release/8.0] Stop using case-insensitive comparisons for indexed properties (#32899) Jan 25, 2024
@ajcvickers ajcvickers added this to the 8.0.x milestone Jan 25, 2024
@rbhanda rbhanda modified the milestones: 8.0.x, 8.0.3 Jan 25, 2024
@AndriySvyryd
Copy link
Member

Note that the branch is currently closed

@maumar maumar merged commit a9cea3e into release/8.0 Feb 7, 2024
7 checks passed
@maumar maumar deleted the 240125_IndexThatJimmy branch February 7, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants