[release/9.0-staging] Set the environment when executing Scaffold-DBContext #35693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
force-pushed
the
Issue35641
branch
from
c371e89 to
18fc1d0
Compare
AndriySvyryd
force-pushed
the
Issue35641
branch
from
18fc1d0 to
78ec15a
Compare
SamMonoRT
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35641
Description
In EF 9.0.0 we made a change to set the environment variables
ASPNETCORE_ENVIRONMENTandDOTNET_ENVIRONMENTtoDevelopmentwhen usingIDesignTimeDbContextFactory. But since the code was moved this had an unintended side effect of no longer setting the environment variables duringScaffold-DBContextas it does not useIDesignTimeDbContextFactory.Customer impact
Code that relied on a specific environment is broken. A workaround is to set the environment variables manually.
How found
Multiple customer reports on 9.0.1
Regression
Yes, from 9.0.0, introduced in #35230
Testing
Tests added.
Risk
Low. Design-time only