[release/8.0-staging] Improve LoadExtension to work correctly with dotnet run and lib* named libs #35718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
force-pushed
the
sqlite-load-extension-8
branch
from
263a7b1 to
20d9556
Compare
roji
force-pushed
the
sqlite-load-extension-8
branch
from
20d9556 to
dada4a1
Compare
…d libs * Improve LoadExtension to work correctly with dotnet run and lib packages * Use [] instead of Array.Empty (cherry picked from commit b1d34dc)
roji
force-pushed
the
sqlite-load-extension-8
branch
from
dada4a1 to
43c33dc
Compare
AndriySvyryd
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #35617 (see #35717 for 9.0 backport PR)
Closes #35715
Description
This improves the extension loading logic of Microsoft.Data.Sqlite to attempt to load native extensions from additional standard native library locations. This is particularly important to SQLite vector database support, which will become our first getting started sample for vector databases with Microsoft.Extensions.VectorData etc. This is an important part of the .NET Intelligent Apps story.
Customer impact
This enables nuget packages to bundle extension native binaries (e.g. sqlite_vec), and for SQLite to just pick them up without any additional obscure handling of native library loading paths.
How found
Path of SQLite vector data investigative work by @krwq.
Regression
No
Testing
Manual testing performed.
Risk
Very low - only adds additional attempts to load from. Quirked.
/cc @krwq