[release/9.0-staging] Process Coalesce-simplified Convert node properly in funcletizer #35721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
approved these changes
Mar 3, 2025
roji
force-pushed
the
FuncletizerCoalesce9
branch
from
f8d2928 to
8f3fce9
Compare
Fixes dotnet#35656 (cherry picked from commit c54f51d)
roji
force-pushed
the
FuncletizerCoalesce9
branch
from
8f3fce9 to
300202b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #35657
Fixes #35656
Description
The expression tree funcletizer - an important query component - was rewritten in EF 9.0 for NativeAOT support and for better performance. Unfortunately, some bugs were introduced in the process.
Customer impact
In some scenarios, when a coalesce operator is used in a query with a nullable value type, an exception is thrown.
How found
Reported by a user against 9.
Regression
Yes.
Testing
Added test
Risk
Very low - very minimal change; added quirk.