Repository navigation
Add a validation step for the specified models. - #39338
Closed
AndriySvyryd wants to merge 2 commits into
Closed
AndriySvyryd wants to merge 2 commits into
AndriySvyryd wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new integration test does not propagate its SDK mock to the grading subprocess, introducing authentication and network dependencies.
1 open issue
What changed in this PR
Adds model validation to the evaluation harness’s judge SDK adapter, rejecting unavailable models before session creation.
Changes:
- Validates model IDs while preserving automatic routing and custom providers.
- Extends tests for model rejection, timeout behavior, and CLI parameter forwarding.
| File | Description |
|---|---|
| eng/harness-evaluation/test/harness.test.mjs | Adds model-validation and launcher regression coverage. |
| eng/harness-evaluation/src/judge-timeout-loader.mjs | Validates judge models against the SDK catalog. |
Review effort: Balanced
Update spawnSync options to include environment variables. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Code coverage overviewLanguages: C# C# / code-coverage
View coverage of the 10 most impacted files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. |
Member
Author
|
This would be better handled at the Vally/Copilot SDK level |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.