Repository navigation
Update Vally packages to 0.20.0 - #39461
Conversation
- Upgrade Vally packages to 0.20.0 and refresh vulnerable transitive dependencies. - Adapt harness timeout integration to Vally 0.20. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the Vally 0.20.0 upgrade and judge-timeout integration changes.
No open issues 🎉
1 file not reviewed
eng/harness-evaluation/package-lock.json: Generated file
What changed in this PR
Updates EF Core’s harness-evaluation tooling to Vally 0.20.0 and adapts its judge-timeout integration to the new behavior.
Changes:
- Upgrades Vally packages, refreshes transitive dependencies, and adds a Copilot SDK–scoped Zod override.
- Removes the obsolete SDK timeout-cap patch and forwards explicit timeouts to native CLI commands.
- Updates regression tests for timeout handling, CLI argument placement, and validation messages.
| File | Description |
|---|---|
eng/harness-evaluation/test/harness.test.mjs |
Updates timeout, CLI, and mock SDK expectations. |
eng/harness-evaluation/src/vally.mjs |
Forwards explicit judge timeouts after the command or subcommand. |
eng/harness-evaluation/src/judge-timeout-loader.mjs |
Removes the obsolete SDK timeout-cap replacement. |
eng/harness-evaluation/package.json |
Pins Vally 0.20.0 and adds the scoped Zod override. |
eng/harness-evaluation/package-lock.json |
Records upgraded dependencies and refreshed integrity hashes. |
Review effort: Balanced
Code coverage overviewLanguages: C# C# / code-coverage
View coverage of the 10 most impacted files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
Vally 0.20 loader compatibility, native timeout/CLI integration tests, and npm audit support through the new proxy remain unverified without dependencies and network execution.
No open issues 🎉
1 file not reviewed
eng/harness-evaluation/package-lock.json: Generated file
Review effort: Balanced
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Agent evaluation:
|
Agent evaluation:
|
Agent evaluation:
|
Agent evaluation:
|
Agent evaluation:
|
Agent evaluation:
|
Agent evaluation:
|
Agent evaluation:
|
Agent evaluation:
|
Agent evaluation:
|
Agent evaluation:
|
Agent evaluation:
|
Agent evaluation:
|
Agent evaluation:
|
Agent evaluation:
|
Agent evaluation:
|
Agent evaluation:
|
Agent evaluation:
|
Updates Vally and Vally CLI to 0.20.0, refreshes vulnerable transitive dependencies, and applies a scoped Zod override for the Copilot SDK. Adapts the judge-timeout integration for Vally 0.20.
Also switches the npm repository to dotnet-public-npm.