-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata reports generator (Issue #3999) #5531
base: main
Are you sure you want to change the base?
Conversation
@dotnet-policy-service agree |
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=895801&view=codecoverage-tab |
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=901527&view=codecoverage-tab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to update this file https://github.com/dotnet/extensions/blob/main/src/Packages/Microsoft.Extensions.AuditReports/README.md ?
...es/Microsoft.Extensions.AuditReports/buildTransitive/Microsoft.Extensions.AuditReports.props
Outdated
Show resolved
Hide resolved
Thank you for taking care of it! |
I think We need to introduce new bullet in the available repots list :
And I also think We need to introduce the new properties to the Available reports Table
|
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=920916&view=codecoverage-tab |
Yes, that makes sense. + maybe a new section like "Example of a metadata report". |
I have updated the read me file , hopefully now it algins with the other reports .... |
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=921170&view=codecoverage-tab |
</PropertyGroup> | ||
|
||
<PropertyGroup> | ||
<Stage>normal</Stage> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I think the PR is in a good shape now, just added some minor comments. Once we confirm the stage policy, it can be merged |
@evgenyfedorov2 All should be good now |
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=922034&view=codecoverage-tab |
This Pull request fixes #3999
if you have any notes I will fix them at once, thank you
Microsoft Reviewers: Open in CodeFlow