#5962 Change to early return of OS instead of throwing #5963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make sure that the executed code only works in scenarios that are supported, which is Windows and Linux. This is particularly important for teams working on different operating systems, and running the code without containerization.
evgenyfedorov2
added
waiting-author-feedback 📭
dotnet-policy-service
bot
removed
the
waiting-author-feedback 📭
|
I am looking forward to this change as I too am on a mac and am experiencing the same issue. Why is this only a draft? It looks good to me :) |
|
@evgenyfedorov2 It passes tests now. Is there anything we would like more? |
| @@ -63,13 +63,17 @@ private static IServiceCollection AddResourceMonitoringInternal( | |||
| this IServiceCollection services, | |||
There was a problem hiding this comment.
This method can now be fully covered by unit tests, please remove the comment and ExcludeFromCodeCoverage attribute
Yeah, please just add more tests, I left a comment. |
evgenyfedorov2
removed
the
* NO MERGE *
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make sure that the executed code only works in scenarios that are supported, which is Windows and Linux. This is particularly important for teams working on different operating systems, and running the code without containerization.
Addresses: #5962
Microsoft Reviewers: Open in CodeFlow