-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[automated] Merge branch 'main' => 'dev' #6133
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
* Memory usage in Slice path could be 0 * Update memory usage test to handle zero values and refine method name * Update error message for memory usage exception to clarify non-negative expectation * Merge test cases
* Add options to log unsupported routes * Refactor * Refactor * Refactor
The fix ensures that the root level of the scenario tree is expanded by default when the report is opened. Also includes a change to ensure that we collapse single child nodes only once right after the tree is constructed, plus a couple of other minor tweaks. --------- Co-authored-by: Peter Waldschmidt <[email protected]>
Co-authored-by: Jeff Handley <[email protected]>
* Add AsChatClient for OpenAIResponseClient * Address feedback
…ng (#6064) * Use strict by default for OpenAI schemas * Fix up remaining places that handle strict --------- Co-authored-by: Daniel Winkler <[email protected]> Co-authored-by: Stephen Toub <[email protected]>
The CreateFunctionJsonSchema method includes all parameters in the schema. If someone wants to exclude a parameter, e.g. because the LLM shouldn't recognize that parameter and the value for the argument will instead come from somewhere else when the function is invoked, there's no good way to achieve that while still using this helper. This PR adds an IncludeParameter filter to the create options, such that a developer can supply a delegate invoked for each ParameterInfo to declare whether that parameter should be included or not.
…314.2 (#6131) [main] Update dependencies from dotnet/arcade - Merge branch 'main' into darc-main-289350a0-a0a2-46cd-9ff0-6b70b2a619ee
RussKie
approved these changes
Mar 17, 2025
5f82075
to
8002436
Compare
Fixes an issue where versions in package references to just-built packages were not always being scrubbed correctly. Prior to this PR, specific version suffixes (-ci, -dev) were scrubbed, but this new PR takes a more robust approach that looks for <PackageReference /> items to just-built packages and scrubs the suffix of the Version attribute. There's a static field _packagePrefixesWithJustBuiltVersionNumber that can be extended with more package prefixes that are expected to have a just-built version number. If we're willing to be less conservative, we could even go even further and scrub any references to Microsoft.Extensions.* packages. Fixes #6128
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@dotnet/dotnet-extensions-ai-evaluation the build is consistently failing with:
|
* HybridCache: richer detection for field-only types (ref STJ) fix dotnet/aspnetcore#60934 * as per PR notes: only apply field-only test versus the *default* options instance * add dictionary test
I think this is a bug in the SDK, but temporarily I have made a change to only ship the tool compiled for net8. #6148 |
Filed bug dotnet/sdk#47696 |
* Use only a single TFM for M.E.AI.Eval.Reporting.Console * Add comment noting the bug,
Thank you @peterwald, let's see if it fixes the build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I detected changes in the main branch which have not been merged yet to dev. I'm a robot and am configured to help you automatically keep dev up to date, so I've opened this PR.
This PR merges commits made on main by the following committers:
Instructions for merging from UI
This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.
If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.
Instructions for merging via command line
Run these commands to merge this pull request from the command line.
or if you are using SSH
After PR checks are complete push the branch
Instructions for resolving conflicts
Instructions for updating this pull request
Contributors to this repo have permission update this pull request by pushing to the branch 'merge/main-to-dev'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.
The provided examples assume that the remote is named 'origin'. If you have a different remote name, please replace 'origin' with the name of your remote.
or if you are using SSH
Contact .NET Core Engineering (dotnet/dnceng) if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/main/.github/workflows/scripts/inter-branch-merge.ps1.
Microsoft Reviewers: Open in CodeFlow