-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove non-AsXx surface area from M.E.AI.OpenAI/AzureAIInference #6138
base: main
Are you sure you want to change the base?
Conversation
src/Libraries/Microsoft.Extensions.AI.AzureAIInference/AzureAIInferenceChatClient.cs
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIModelMapper.ChatMessage.cs
Show resolved
Hide resolved
This is certainly all good stuff in general. Within the |
src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIRealtimeExtensions.cs
Show resolved
Hide resolved
We expect the AsChatClient/AsEmbeddingGenerator extension methods from M.E.AI.OpenAI and M.E.AI.AzureAIInference to move into the OpenAI / Azure.AI.Inference libraries, respectively. To prepare for that, and the temporary M.E.AI.OpenAI/AzureAIInference libs then being deprecated, this PR removes the other surface area from these assemblies. For anything folks found useful, we should find another way to ship it, likely just as sample source somewhere.
Only meaningful code changes are deleting the extension methods on OpenAIClient (keeping the ones on ChatClient / EmbeddingClient), and renaming the AsChatClient / AsEmbeddingGenerator extension methods to be AsIChatClient / AsIEmbeddingGenerator. Otherwise, "ChatClient" is confusing with the OpenAI type of the same name.
c65858f
to
6f5872d
Compare
This should be ready to go. One important note:
|
We expect the AsChatClient/AsEmbeddingGenerator extension methods from M.E.AI.OpenAI and M.E.AI.AzureAIInference to move into the OpenAI / Azure.AI.Inference libraries, respectively. To prepare for that, and the temporary M.E.AI.OpenAI/AzureAIInference libs then being deprecated, this PR removes the other surface area from these assemblies. For anything folks found useful, we should find another way to ship it, likely just as sample source somewhere.
Closes #6094
Closes #5965
Closes #5964
Microsoft Reviewers: Open in CodeFlow