Skip to content

Conversation

majocha
Copy link
Contributor

@majocha majocha commented Sep 17, 2025

Description

Running dotnet build VisualFSharp.sln fails with error:

error MSB3823: Non-string resources require the property GenerateResourceUsePreserializedResources to be set to true.

So let's set it to true and see it anything breaks.

Should fix #18886.

Copy link
Contributor

github-actions bot commented Sep 17, 2025

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@T-Gro T-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Sep 17, 2025
@majocha majocha marked this pull request as draft September 17, 2025 17:30
@majocha
Copy link
Contributor Author

majocha commented Sep 17, 2025

I see it didn't work in general, this breaks another things (VSSDK1012: The cto merger could not read the data) Maybe copilot can make it conditional, but I doubt.

@majocha
Copy link
Contributor Author

majocha commented Sep 17, 2025

After some begging alternated with threats of violence, Copilot came up with something that works. I managed to build VisualFSharp.sln in Rider with this:
image
This probably won't work directly from a clean repo, though.
Also this needs a double check if all the resources are still embedded correctly in the vsix.

@majocha
Copy link
Contributor Author

majocha commented Sep 18, 2025

Now, this is very incompatible with BUILDING_USING_DOTNET env variable.
So, in a clean repo you need to at least build bootstrap first:

git clean -xdf -e .vs -e .dotnet

dotnet publish .\proto.proj -c Proto

then this should work from Rider and from commandline

dotnet build .\VisualFSharp.sln

as a bonus, now the msbuildengine switch works again:

.\Build.cmd -msbuildengine dotnet

@majocha majocha marked this pull request as ready for review September 18, 2025 07:04
@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling Sep 18, 2025
@T-Gro T-Gro merged commit c061d0f into dotnet:main Sep 18, 2025
38 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in F# Compiler and Tooling Sep 18, 2025
@auduchinok
Copy link
Member

@majocha Thank you very much for investigating and fixing it!

@majocha majocha deleted the fix-dotnet-build branch September 18, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Can't build VisualFSharp.sln using dotnet or Rider
3 participants