Skip to content

Fix dotnet build VisualFSharp.sln #18914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 18, 2025
Merged

Fix dotnet build VisualFSharp.sln #18914

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
35a7a31
do what the error says
majocha Sep 17, 2025
95ceff2
try this
majocha Sep 17, 2025
350d2f8
better condition
majocha Sep 17, 2025
f137e4e
Merge branch 'main' into fix-dotnet-build
majocha Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion vsintegration/src/FSharp.ProjectSystem.FSharp/FSharp.ProjectSystem.FSharp.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,13 @@
<DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
<OtherFlags>$(OtherFlags) --subsystemversion:6.00</OtherFlags>
<EnableDefaultEmbeddedResourceItems>false</EnableDefaultEmbeddedResourceItems>
<!-- Enable preserialized resources by default (required by newer SDKs for non-string resources). -->
<GenerateResourceUsePreserializedResources>true</GenerateResourceUsePreserializedResources>
</PropertyGroup>

<!-- When building with desktop MSBuild (Full), fall back to legacy resources so the CTO merger (VSSDK) can read .resources files. -->
<PropertyGroup Condition="'$(MSBuildRuntimeType)' != 'Core'">
<GenerateResourceUsePreserializedResources>false</GenerateResourceUsePreserializedResources>
</PropertyGroup>

<ItemGroup>
Expand All @@ -28,7 +35,8 @@
<EmbeddedResource Include="VSPackage.resx">
<GenerateSource>true</GenerateSource>
<GeneratedModuleName>Microsoft.VisualStudio.FSharp.ProjectSystem.FSharpSR</GeneratedModuleName>
<MergeWithCTO>true</MergeWithCTO>
<!-- Only merge with CTO when building with desktop MSBuild (typical for VS/VSSDK builds). Skip for dotnet (MSBuild Core). -->
<MergeWithCTO Condition="'$(MSBuildRuntimeType)' != 'Core'">true</MergeWithCTO>
<ManifestResourceName>VSPackage</ManifestResourceName>
<SubType>Designer</SubType>
<IntermediateTargetPath>$(IntermediateOutputPath)resources\</IntermediateTargetPath>
Expand Down
Loading