Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment: Use ALC in FSI sessions when on coreclr #16748

Closed
wants to merge 1 commit into from

Conversation

vzarytovskii
Copy link
Member

@vzarytovskii vzarytovskii commented Feb 22, 2024

Description

This is an attempt (timebox really) to improve #15669 by using unloadable ALC, if anyone wants to help testing it, it will be appreciated.

Fixes #15669

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/releae-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

Copy link
Contributor

❗ Release notes required

@vzarytovskii,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.300.md No release notes found or release notes format is not correct

@vzarytovskii
Copy link
Member Author

It's failing to load FSI-ASSEMBLY now. It will need more work and debugging. I may come back to it in the future, or anyone else is free to investigate.

@vzarytovskii
Copy link
Member Author

That didn't work out, not gonna delete branch if anyone will want to pick it up.

@majocha
Copy link
Contributor

majocha commented Nov 5, 2024

IIUC conditional compilation is out of question here? I'm thinking trying an unloadable sub AppDomain for legacy version and an ALC for core, but with netstandard2.0 it seems neither are supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

FsiEvaluationSession.Create does not unload FSI-ASSEMBLY when collectible = true
2 participants