Design doc on reusing typechecking results #17368
Conversation
✅ No release notes required |
|
@psfinaki Thanks for starting this initiative, this may noticeably improve things! I can add two things to consider:
|
psfinaki
changed the title
Co-authored-by: Tomas Grosup <[email protected]>
Co-authored-by: Tomas Grosup <[email protected]>
…into reuse-typecheck
Co-authored-by: Tomas Grosup <[email protected]>
Co-authored-by: Tomas Grosup <[email protected]>
psfinaki
changed the title
|
|
||
| Optimizations are not relevant in the dev loop with run/debug/test cycles so we won't take those into account. | ||
|
|
||
| ## Implementation plan |
There was a problem hiding this comment.
Can you also please add any potential challenges in implementing each stage?
|
|
||
| That means we can force-gen and save the graph which will allow us to skip retypechecking if we detect that the graph is not changed. We should also track all the compilation information (the argument string). | ||
|
|
||
| This step won't bring big observable benefits, yet it will create necessary MSBuild hooks to communicate the intermediate files folder towards the compiler, add time-based and hash-based cache invalidation logic, and create testing rails which will include the `clean` and `rebuild` tests to make sure the cache is easily invalidated on demand. |
There was a problem hiding this comment.
time-based and hash-based cache invalidation logic
This is the fun part. The hash of each file should contain also all its dependencies. It's kinda the same problem FSharpProjectSnapshot is trying to solve. It would be nice if we could somehow unify this.
The design for #17260.