Make nullness equivalent warning message clearer.

[isaacabraham]

Description

Fixes #18171. Warning now reads:

Nullness warning: A non-nullable 'String' was expected but this expression is nullable. Consider either changing the target to also be nullable, or use pattern matching to safely handle the null case of this expression.

Checklist

• Test cases updated

NO_RELEASE_NOTES

[github-actions]

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

[isaacabraham]

Is this failing because of the lack of release notes or have I botched something else?

Also - what causes the BSL files to get regenerated? I ended up doing it by hand.

[majocha]

@isaacabraham looks like the only error apart from lack of release notes was this crash. If it passes locally it is most probably good.

[smoothdeveloper]

@isaacabraham setting the environment variable TEST_UPDATE_BSL to 1 and running the test should update your .bsl files.

[isaacabraham]

@isaacabraham setting the environment variable TEST_UPDATE_BSL to 1 and running the test should update your .bsl files.

By running build -TEST or is there a quicker way of doing it?

[smoothdeveloper]

You can hijack the check of that variable:

fsharp/tests/FSharp.Test.Utilities/Compiler.fs

Line 1121 in 2c3bdcb

if updateBaseline () then

fsharp/tests/FSharp.Test.Utilities/SurfaceArea.fs

Line 74 in 2c3bdcb

match Environment.GetEnvironmentVariable("TEST_UPDATE_BSL") with

Or if you run the suite from command line, using set TEST_UPDATE_BSL=1 per the dev guidelines:

fsharp/DEVGUIDE.md

Line 192 in 2c3bdcb

set TEST_UPDATE_BSL=1

[isaacabraham]

@isaacabraham looks like the only error apart from lack of release notes was this crash. If it passes locally it is most probably good.

Any idea how to make this green?

[majocha]

Any idea how to make this green?

Just rerun the CI and hopefully the tests will not crash the CLR this time. To rerun you can close and reopen the PR or just add another commit with release notes. Sorry for the tests being a bit unstable in CI right now. I hope this will help when merged: #18169.

[isaacabraham]

Any idea how to make this green?

Just rerun the CI and hopefully the tests will not crash the CLR this time. To rerun you can close and reopen the PR or just add another commit with release notes. Sorry for the tests being a bit unstable in CI right now. I hope this will help when merged: #18169.

For the release notes, what can I do to fix that - which file needs updating?

[psfinaki]

@isaacabraham no need for release notes here, the release notes check in this PR is already lifted and the CI is green :)

FYI, when there is a need for them, the respective comment points to the exact release note which requires an update.

[psfinaki]

Right, this is a more helpful diagnostic, thanks!