Fix fsi auto-loading of script file inside NuGet package.

[teo-tsirpanis]

Description

In the project file generated by FSharp.DependencyManager.NuGet, we've been referencing a PackageRoot item metadata that does not exist (line 136), causing inability to find the script file,

Fixes #18176 as validated locally by patching the FSharp.DependencyManager.Nuget.dll of a .NET SDK installation.

Checklist

• Test cases added

• Performance benchmarks added in case of performance changes

• Release notes entry updated:

  Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

  Release notes files:

  • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
  • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/release-notes/.Language/preview.md
  • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

  Information about the release notes entries format can be found in the documentation.
  Example:

  • More inlines for Result module. (PR #16106)
  • Correctly handle assembly imports with public key token of 0 length. (Issue #16359, PR #16363)
    *while! (Language suggestion #1038, PR #14238)

  If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

[github-actions]

✅ No release notes required

[baronfel]

This MSBuild-fu is good.

[T-Gro]

This is a good fix.

@teo-tsirpanis We do have some existing tests which use "nuget: .." dependency loading and validating some cases.

Do you have a package where the fixed behavior happens?
If yes, could this be added as a test?

[KevinRansom]

looks good.

[KevinRansom]

I will take a look at the test failures.

[KevinRansom]

The test failures are signficant.

[teo-tsirpanis]

@KevinRansom CI is now green. @T-Gro I will make use of this for the next version of the Farkle library, but it is not yet published. I don't know any other package that does this.