Wrap arg in parens when needed when adding new
keyword
#18179
Merged
+209
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
new
keyword" code fix to wrap the constructor argument in parentheses when needed, so that applying the fix does not cause Inconsistent handling of arguments for disposable types #15622.This change incidentally also prevents the code fix from suggesting a "fix" that would be invalid in various scenarios,1 e.g.:
Checklist
Footnotes
We could in theory update the code fix to suggest
new (Disposable)(arg)
(or evennew Disposable(arg)
),xs |> List.map (fun x -> new Disposable(x))
, etc., for such scenarios, but I considered that out of scope for this PR—and perhaps altogether, since transformations likexs |> List.map (fun x -> new Disposable(x))
also may not be valid, depending on the type of the constructor argument! For example, ifxs
is aunit list
, then transformingxs |> List.map Disposable
toxs |> List.map (fun x -> new Disposable(x))
is not valid. ↩