Improve directory attribute refactor - Break up PR #18161 - Part 1 #18195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ No release notes required |
KevinRansom
force-pushed
the
ImproveDirectoryAttribute.Refactor
branch
from
e0b845d to
e2b0db7
Compare
T-Gro
reviewed
Jan 3, 2025
| try | ||
| Directory.Delete(initialProject.ProjectDir, true) | ||
| with _ -> () | ||
| () //try Directory.Delete(initialProject.ProjectDir, true) with _ -> () |
There was a problem hiding this comment.
Why are we not deleting?
Do we need a methodcall which is a conditional no-op?
T-Gro
reviewed
Jan 3, 2025
| @@ -19,7 +19,7 @@ let tempDirectoryOfThisTestRun = | |||
|
|
|||
| let cleanUpTemporaryDirectoryOfThisTestRun () = | |||
| if tempDirectoryOfThisTestRun.IsValueCreated then | |||
| try tempDirectoryOfThisTestRun.Value.Delete(true) with _ -> () | |||
| () //try tempDirectoryOfThisTestRun.Value.Delete(true) with _ -> () | |||
T-Gro
reviewed
Jan 3, 2025
| @@ -244,7 +244,7 @@ An error occurred getting netcoreapp references: %A{e} | |||
| raise (Exception (message, e)) | |||
| finally | |||
| if cleanUp then | |||
| try Directory.Delete(projectDirectory, recursive=true) with | _ -> () | |||
| () //try Directory.Delete(projectDirectory, recursive=true) with | _ -> () | |||
T-Gro
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks up the directory attribute refactor, which is enormous.
This inital PR contains the test framework code changes.
And 1 quite large folder of test cases that use baselines a fair amount.
/cc @T-Gro